у нас есть 2 Смарт Контракта, и есть список исправлений по ним, нужно все исправления сделать за сегодня, их немного. все данные предоставлю в лс.
Сами ошибки
Critical Severity
• Line 251 – There is no checking if the referrer is same as referral. This allows users to make self referred deposits
• Line 187,192,197,202 – Owner has high privilages to change tokenomics and passive contracts anytime
Medium Severity
• Line 207 – Fallback function is commented out
• Line 930 – setPassive function is accessible to public. Better restrict it to onlyOwner
• Line 259,1036 – Functions defined, but not used even once in the contract
Low Severity
• Line 584,595,606,617,628,639,650,661,672,683,694,705 – Use a common function which can call these functions by a given parameter. It will reduce the code length greatly
• Line 80,85,168,187,192,202,266,502,577 – Usage of external instead of
public is more promoted
• Line 906,907,1054 – Visibility is not defined
Other Findings
• Line 226 – Storing loop control variable in another variable will reduce gas fee
• Line 266 – Using pre computed values will help reducing gas fee (ex:10*6 can be directly written as 60)
• Line 266 – Use loop to fold the if conditions and reduce size of code
• Safemath is used excessively. Only use safemath when there is a chance of arithmetic overflow occurs
